Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web3-eth-contract: add typescript definitions for methods and call #3454

Merged
merged 5 commits into from
May 5, 2020

Conversation

Velua
Copy link
Contributor

@Velua Velua commented Apr 3, 2020

Description

Added Typescript definition for 'methods'

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I have executed npm run test:cov and my test cases do cover all lines and branches of the added code.
  • I ran npm run build-all and tested the resulting file/'s from dist folder in a browser.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the live network.

@coveralls
Copy link

coveralls commented Apr 3, 2020

Coverage Status

Coverage remained the same at 88.596% when pulling 7513a7f on Velua:1.x into 3684fc3 on ethereum:1.x.

@cgewecke cgewecke added 1.x 1.0 related issues Types Incorrect or missing types labels Apr 7, 2020
@ryanio ryanio changed the title added method return web3-eth-contract: add typescript definitions for methods and call Apr 10, 2020
Copy link
Collaborator

@ryanio ryanio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ryanio ryanio merged commit 9313265 into web3:1.x May 5, 2020
@cgewecke cgewecke added this to Done in v1.2.8 May 8, 2020
@ryanio ryanio mentioned this pull request May 8, 2020
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Types Incorrect or missing types
Projects
No open projects
v1.2.8
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants