Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade CI Provider from Travis to GH Actions #3468

Merged
merged 6 commits into from
Apr 17, 2020
Merged

Upgrade CI Provider from Travis to GH Actions #3468

merged 6 commits into from
Apr 17, 2020

Conversation

ryanio
Copy link
Collaborator

@ryanio ryanio commented Apr 13, 2020 •
edited

Description

This PR upgrades the CI provider from Travis to GH Actions for better speed and workflow integration.

This PR:

  • Updates Travis references to GH Actions.
  • Removes coveralls devDep in favor pushing to Coveralls through GH Actions.
    • Benefits: coverage reporting on forks, one less devDep
  • Verdaccio: adds yarn as a fallback upstream proxy.
  • Various increased config timeouts to allow for larger npm packages to download.

Closes #3393

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I have executed npm run test:cov and my test cases do cover all lines and branches of the added code.
  • I ran npm run build-all and tested the resulting file/'s from dist folder in a browser.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the live network.

@ryanio ryanio added 1.x 1.0 related issues CI labels Apr 13, 2020
@github-actions
Copy link

Coverage Status

Coverage remained the same at 88.596% when pulling 30f0d30 on useGithubActions into 3684fc3 on 1.x.

@ryanio ryanio changed the title Test Using Github Actions Upgrade CI Provider from Travis to GH Actions Apr 13, 2020
cgewecke
cgewecke reviewed Apr 15, 2020
View reviewed changes
.github/workflows/test.yml Outdated
runs-on: ubuntu-latest
strategy:
matrix:
node: [8, 10, 11, 12]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does 13 also work by any chance? (Was reminded about this possibility by #3473....)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes i'll add it!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like ran into the same error: https://github.com/ethereum/web3.js/pull/3468/checks?check_run_id=590277057#step:4:64

@ryanio ryanio added the In Progress Currently being worked on label Apr 15, 2020
@ryanio ryanio force-pushed the useGithubActions branch 5 times, most recently from ed17f84 to 7bacb68 Compare April 16, 2020 00:56
@cgewecke cgewecke mentioned this pull request Apr 16, 2020
Closed
@cgewecke cgewecke self-requested a review April 16, 2020 20:30
cgewecke
cgewecke approved these changes Apr 16, 2020
View reviewed changes
Copy link
Collaborator

@cgewecke cgewecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! 🎉

@cgewecke
Copy link
Collaborator

cgewecke commented Apr 16, 2020 •
edited

Ai! Build!!! Why??

@ryanio ryanio merged commit 0733765 into 1.x Apr 17, 2020
@holgerd77 holgerd77 deleted the useGithubActions branch April 17, 2020 21:16
@ryanio ryanio mentioned this pull request May 8, 2020
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgewecke cgewecke cgewecke approved these changes

Assignees
No one assigned
Labels
1.x 1.0 related issues In Progress Currently being worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move from Travis to GitHub Actions
2 participants
@ryanio @cgewecke