Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fix on web3-eth.rst documentation #3478

Merged
merged 6 commits into from
Apr 28, 2020
Merged

Small fix on web3-eth.rst documentation #3478

merged 6 commits into from
Apr 28, 2020

Conversation

0xGabi
Copy link
Contributor

@0xGabi 0xGabi commented Apr 16, 2020

Description

Reading the documentation I notice there was a small typo on the web3.eth.getProof example. This PR fix that.

Type of change

  • Documentation fix

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I have executed npm run test:cov and my test cases do cover all lines and branches of the added code.
  • I ran npm run build-all and tested the resulting file/'s from dist folder in a browser.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the live network.

@cgewecke cgewecke added 1.x 1.0 related issues Documentation Relates to project wiki or documentation labels Apr 16, 2020
@cgewecke cgewecke self-requested a review April 16, 2020 19:55
Copy link
Collaborator

@cgewecke cgewecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @0xGabi

@cgewecke
Copy link
Collaborator

NB: CI is failing on a couple tests because of change in Geth's default behavior described in #3456

Have just patched it In #3477. Will wait till that merges and then we'll rebase here.

@cgewecke cgewecke added this to In progress in v1.2.8 Apr 25, 2020
@cgewecke cgewecke moved this from In progress to Review in v1.2.8 Apr 25, 2020
@cgewecke cgewecke moved this from Review to In progress in v1.2.8 Apr 25, 2020
@cgewecke cgewecke merged commit bcf248f into web3:1.x Apr 28, 2020
@cgewecke cgewecke moved this from In progress to Done in v1.2.8 Apr 28, 2020
@ryanio ryanio mentioned this pull request May 8, 2020
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Documentation Relates to project wiki or documentation
Projects
No open projects
v1.2.8
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants