Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated types for web3 http provider #3335 #3482

Merged
merged 4 commits into from
May 5, 2020
Merged

Conversation

viswanathkgp12
Copy link
Contributor

Description

Updated type definitions for Web3 HTTP Provider 1.x

Fixes #3335

Type of change

  • Extends types (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I have executed npm run test:cov and my test cases do cover all lines and branches of the added code.
  • I ran npm run build-all and tested the resulting file/'s from dist folder in a browser.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the live network.

Copy link
Collaborator

@ryanio ryanio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, LGTM!

@ryanio ryanio merged commit 0d0adde into web3:1.x May 5, 2020
@cgewecke cgewecke added this to Done in v1.2.8 May 8, 2020
@ryanio ryanio mentioned this pull request May 8, 2020
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
v1.2.8
  
Done
Development

Successfully merging this pull request may close these issues.

Improving of the provider related TS type tests
2 participants