Add EIP-1193 compatible provider to AbstractProvider interface #3499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanio
force-pushed
the
addEIP1193
branch
3 times, most recently
from
28d6203
to
6e058a3
Compare
cgewecke
reviewed
May 7, 2020
| @@ -19,7 +19,6 @@ | |||
| */ | |||
|
|
|||
| import * as net from 'net'; | |||
| import { EventEmitter } from "events" | |||
cgewecke
reviewed
May 7, 2020
packages/web3-core/types/index.d.ts
Outdated
| sendAsync(payload: JsonRpcPayload, callback: (error: Error | null, result?: JsonRpcResponse) => void): void; | ||
| send?(payload: JsonRpcPayload, callback: (error: Error | null, result?: JsonRpcResponse) => void): void; | ||
| request?(args: RequestArguments): Promise<unknown>; |
There was a problem hiding this comment.
Purely out of curiosity, what's the behavior of unknown here when assigning the result? Like, do you have to cast it or it "just works".
There was a problem hiding this comment.
Ah yes thanks I'll change to any since unknown will force the user to type cast the result and I don't think we need to enforce that.
cgewecke
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR builds on #3451 by adding a EIP-1193 compatible provider to
AbstractProviderwith the optional methodrequest(args: RequestArguments): Promise<unknown>.Type of change
Checklist:
npm run dtslintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:covand my test cases cover all the lines and branches of the added code.npm run build-alland tested the resulting files fromdistfolder in a browser.CHANGELOG.mdfile in the root folder.