Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More about encodeABI #3549

Merged
merged 3 commits into from
Jun 2, 2020
Merged

More about encodeABI #3549

merged 3 commits into from
Jun 2, 2020

Conversation

miohtama
Copy link
Contributor

Description

Somebody asked about encodeABI so decided to add some colour for the function description.

Type of change

Docs

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build-all and tested the resulting files from dist folder in a browser.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the live network.

Somebody asked about encodeABI so decided to add some colour for the function description.
@coveralls
Copy link

coveralls commented May 28, 2020

Coverage Status

Coverage remained the same at 89.638% when pulling 8e830e4 on miohtama:patch-3 into 3a9c1ad on ethereum:1.x.

Copy link
Collaborator

@cgewecke cgewecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @miohtama! This is a really helpful clarification. 💯

ryanio and others added 2 commits June 1, 2020 17:01
Co-authored-by: cgewecke <christophergewecke@gmail.com>
@ryanio
Copy link
Collaborator

ryanio commented Jun 2, 2020

thanks @miohtama!

@ryanio ryanio merged commit 5829347 into web3:1.x Jun 2, 2020
@cgewecke cgewecke added this to Done in v1.2.9 Jun 2, 2020
@ryanio ryanio mentioned this pull request Jun 2, 2020
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
v1.2.9
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants