Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #4210, 4211 - allow non-hex values for eip1559 gas params #4217

Merged
merged 6 commits into from Jul 31, 2021

Conversation

GregTheGreek
Copy link
Contributor

@GregTheGreek GregTheGreek commented Jul 31, 2021

Description

Updates the transaction input formatter to allow the new 1559 gas params to be represented as numbers, bn, string numbers, etc... and then converted to a hex.

Closes #4210 Closes #4211

Note: Still need to add test cases, in transit rn.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@GregTheGreek GregTheGreek added the P1 High severity bugs label Jul 31, 2021
@render
Copy link

render bot commented Jul 31, 2021

@coveralls
Copy link

coveralls commented Jul 31, 2021

Pull Request Test Coverage Report for Build 1085839186

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • 270 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+2.6%) to 75.366%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/web3-core-helpers/src/formatters.js 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
packages/web3-core-requestmanager/src/jsonrpc.js 1 70.0%
packages/web3-core-helpers/src/formatters.js 5 84.39%
packages/web3-core-helpers/lib/formatters.js 17 81.03%
packages/web3-core-helpers/src/errors.js 29 1.56%
packages/web3-utils/src/utils.js 31 8.46%
packages/web3-utils/src/soliditySha3.js 34 3.43%
packages/web3-utils/src/index.js 43 31.38%
packages/web3-eth-accounts/src/index.js 110 26.12%
Totals Coverage Status
Change from base Build 1076530205: 2.6%
Covered Lines: 3180
Relevant Lines: 3992

💛 - Coveralls

@GregTheGreek GregTheGreek changed the title Closes #4210 - allow non-hex values for eip1559 gas params Closes #4210, 4211 - allow non-hex values for eip1559 gas params Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 High severity bugs
Projects
None yet
3 participants