Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format baseFeePerGas to number in returned blocks - Closes #4326 #4330

Merged
merged 8 commits into from Sep 24, 2021

Conversation

spacesailor24
Copy link
Contributor

Closes #4326

As mentioned previously, this is technically a breaking change

@spacesailor24 spacesailor24 added the 1.x 1.0 related issues label Sep 15, 2021
@render
Copy link

render bot commented Sep 15, 2021

nazarhussain
nazarhussain previously approved these changes Sep 16, 2021
@jdevcs
Copy link
Contributor

jdevcs commented Sep 16, 2021

lgtm, also doc update this

@philknows
Copy link

This will be a breaking change. Will need to disseminate information out via community channels before merging.

@spacesailor24 spacesailor24 changed the title Add BigNumber formatter to baseFeePerGas in returned blocks - Closes #4326 Format baseFeePerGas to number string in returned blocks - Closes #4326 Sep 17, 2021
@spacesailor24 spacesailor24 changed the title Format baseFeePerGas to number string in returned blocks - Closes #4326 Format baseFeePerGas to number in returned blocks - Closes #4326 Sep 18, 2021
Copy link
Contributor

@jdevcs jdevcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also update BlockHeader as mentioned by this

jdevcs
jdevcs previously approved these changes Sep 22, 2021
nazarhussain
nazarhussain previously approved these changes Sep 22, 2021
luu-alex
luu-alex previously approved these changes Sep 22, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1263611492

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 261 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+2.4%) to 74.942%

Files with Coverage Reduction New Missed Lines %
packages/web3-core-requestmanager/src/jsonrpc.js 1 70.0%
packages/web3-core-helpers/src/formatters.js 6 84.87%
packages/web3-core-helpers/lib/formatters.js 10 81.23%
packages/web3-core-helpers/src/errors.js 29 1.56%
packages/web3-utils/src/utils.js 31 8.46%
packages/web3-utils/src/soliditySha3.js 34 3.43%
packages/web3-utils/src/index.js 43 31.38%
packages/web3-eth-accounts/src/index.js 107 23.67%
Totals Coverage Status
Change from base Build 1262887513: 2.4%
Covered Lines: 3219
Relevant Lines: 4060

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

web3.eth.getBlock() returns baseFeePerGas field as hex string instead of BN or number
6 participants