Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Nonce must be 8 bytes by Ethereum spec #4559

Merged
merged 4 commits into from
Mar 17, 2022
Merged

Chore: Nonce must be 8 bytes by Ethereum spec #4559

merged 4 commits into from
Mar 17, 2022

Conversation

aeharvlee
Copy link

Description

Nonce cannot be longer than 8 bytes because the nonce is defined as 8 bytes in ethereum.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

fallingicarus
fallingicarus reviewed Nov 22, 2021
View reviewed changes
Copy link

@fallingicarus fallingicarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chore: Nonce must be 8 bytes by Ethereum spec

@github-actions
Copy link

This PR has been automatically marked as stale beacause it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.

@github-actions github-actions bot added the Stale Has not received enough activity label Jan 23, 2022
@aeharvlee
Copy link
Author

This PR has been automatically marked as stale beacause it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.

@fallingicarus
Hi, is there anything left I should go on about this?

@github-actions github-actions bot removed the Stale Has not received enough activity label Jan 24, 2022
@mconnelly8 mconnelly8 added the 1.x 1.0 related issues label Feb 8, 2022
@coveralls
Copy link

coveralls commented Mar 10, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1990661430

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 429 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-2.3%) to 72.688%
Files with Coverage Reduction New Missed Lines %
packages/web3-core-requestmanager/src/jsonrpc.js 1 88.0%
packages/web3-core-helpers/src/formatters.js 25 81.07%
packages/web3-core-helpers/src/errors.js 31 4.41%
packages/web3-utils/src/soliditySha3.js 55 5.13%
packages/web3-utils/src/index.js 62 29.31%
packages/web3-utils/src/utils.js 92 12.86%
packages/web3-eth-accounts/src/index.js 163 23.77%
Totals Coverage Status
Change from base Build 1975083195: -2.3%
Covered Lines: 3383
Relevant Lines: 4397
💛 - Coveralls

@jdevcs jdevcs changed the base branch from 1.x to junaid/nonceFixInTest4559 March 17, 2022 15:21
@jdevcs jdevcs merged commit e2ed7f2 into web3:junaid/nonceFixInTest4559 Mar 17, 2022
@jdevcs jdevcs mentioned this pull request Mar 17, 2022
Merged
16 tasks
jdevcs added a commit that referenced this pull request Mar 17, 2022
@jdevcs @aeharvlee
Nonce must be 8 bytes by Ethereum spec (#4559) (#4865)
c5f3107 
Co-authored-by: Denver <aeharvlee@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fallingicarus fallingicarus fallingicarus approved these changes

@nazarhussain nazarhussain nazarhussain approved these changes

@luu-alex luu-alex luu-alex approved these changes

@jdevcs jdevcs jdevcs approved these changes

@spacesailor24 spacesailor24 Awaiting requested review from spacesailor24

Assignees

@nazarhussain nazarhussain

Labels
1.x 1.0 related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@aeharvlee @coveralls @nazarhussain @luu-alex @jdevcs @fallingicarus @mconnelly8