Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace old xhr2-cookies with local xhr2-cookies-patched deps for 1.x, fix User-Agent header problem #4856

Closed
wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 15, 2022

Description

Supersedes #4808 with xhr2-cookies-patched deps added inside local_modules

Type of change

Replace xhr2-cookies with local fork of https://github.com/0xAyanami/xhr2-cookies.

Every content inside local_modules/xhr2-cookies-patched are cloned from https://github.com/0xAyanami/xhr2-cookies/tree/f4fc83c700758b6b76aa56d815488b3d1a701e73 without changes.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@nazarhussain nazarhussain requested review from jdevcs, nazarhussain, luu-alex and spacesailor24 and removed request for jdevcs March 17, 2022 10:48
@nazarhussain nazarhussain added 1.x 1.0 related issues Review Needed Maintainer(s) need to review labels Mar 17, 2022
Copy link
Contributor

@spacesailor24 spacesailor24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @0xayanami for being so persistent in getting these changes made, we appreciate your efforts in helping us maintain Web3.js. Please see this comment for more info, but we most certainly don't want to maintain this package locally as this PR is proposing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Review Needed Maintainer(s) need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants