Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: assignment to function.call #4918

Merged
merged 6 commits into from
Apr 12, 2022
Merged

fix: assignment to function.call #4918

merged 6 commits into from
Apr 12, 2022

Conversation

Jack-Works
Copy link

@Jack-Works Jack-Works commented Apr 4, 2022 •
edited

Description

image

Assign call property on a function thrown in our environment. I replaced that with defineProperty

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@coveralls
Copy link

coveralls commented Apr 4, 2022 •
edited

Pull Request Test Coverage Report for Build 2093631005

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 429 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-2.3%) to 72.21%
Files with Coverage Reduction New Missed Lines %
packages/web3-core-requestmanager/src/jsonrpc.js 1 88.0%
packages/web3-core-helpers/src/formatters.js 25 81.07%
packages/web3-core-helpers/src/errors.js 31 4.41%
packages/web3-utils/src/soliditySha3.js 55 5.13%
packages/web3-utils/src/index.js 62 29.31%
packages/web3-utils/src/utils.js 92 12.86%
packages/web3-eth-accounts/src/index.js 163 23.77%
Totals Coverage Status
Change from base Build 2029198956: -2.3%
Covered Lines: 3368
Relevant Lines: 4396
💛 - Coveralls

jdevcs
jdevcs reviewed Apr 4, 2022
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
@jdevcs jdevcs added 1.x 1.0 related issues Review Needed Maintainer(s) need to review labels Apr 4, 2022
nazarhussain
nazarhussain approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@nazarhussain nazarhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change seems good to me. But next time try to avoid including white space changes.

@Jack-Works Jack-Works mentioned this pull request Apr 6, 2022
Closed
@Jack-Works
Copy link
Author

Change seems good to me. But next time try to avoid including white space changes.

thanks! they're automatically included by my IDE. I'll try to take care of that next time

@jdevcs jdevcs changed the base branch from 1.x to junaid/4918functioncall_wine2e April 12, 2022 13:26
@jdevcs jdevcs merged commit 40f7d9c into web3:junaid/4918functioncall_wine2e Apr 12, 2022
@jdevcs jdevcs mentioned this pull request Apr 12, 2022
Merged
jdevcs added a commit that referenced this pull request Apr 12, 2022
@jdevcs @Jack-Works
assignment to function.call (#4918) (#4938)
fab97f7 
* fix: assignment to function.call (#4918)

* fix: assignment to call

* docs: add changelog

* Update CHANGELOG.md

Co-authored-by: Junaid <86780488+jdevcs@users.noreply.github.com>

* Update CHANGELOG.md

Co-authored-by: Jack Works <jackworks@protonmail.com>
@jdevcs jdevcs mentioned this pull request May 17, 2022
Merged
@kriskowal kriskowal mentioned this pull request Feb 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nazarhussain nazarhussain nazarhussain approved these changes

@avkos avkos avkos approved these changes

@jdevcs jdevcs jdevcs approved these changes

@spacesailor24 spacesailor24 Awaiting requested review from spacesailor24

Assignees
No one assigned
Labels
1.x 1.0 related issues Review Needed Maintainer(s) need to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Jack-Works @coveralls @nazarhussain @avkos @jdevcs