New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: assignment to function.call #4918
Merged
jdevcs
merged 6 commits into
web3:junaid/4918functioncall_wine2e
from
Jack-Works:fix-call
Apr 12, 2022
Merged
fix: assignment to function.call #4918
jdevcs
merged 6 commits into
web3:junaid/4918functioncall_wine2e
from
Jack-Works:fix-call
Apr 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2093631005
💛 - Coveralls |
jdevcs
reviewed
Apr 4, 2022
avkos
approved these changes
Apr 5, 2022
jdevcs
approved these changes
Apr 5, 2022
nazarhussain
approved these changes
Apr 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change seems good to me. But next time try to avoid including white space changes.
thanks! they're automatically included by my IDE. I'll try to take care of that next time |
jdevcs
added a commit
that referenced
this pull request
Apr 12, 2022
* fix: assignment to function.call (#4918) * fix: assignment to call * docs: add changelog * Update CHANGELOG.md Co-authored-by: Junaid <86780488+jdevcs@users.noreply.github.com> * Update CHANGELOG.md Co-authored-by: Jack Works <jackworks@protonmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Assign
call
property on a function thrown in our environment. I replaced that withdefineProperty
Type of change
Checklist:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:cov
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.