Fixed unit tests & removed dead code for web3-providers-http #5228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2694984724
💛 - Coveralls |
This was referenced Jul 13, 2022
nazarhussain
approved these changes
Jul 14, 2022
luu-alex
approved these changes
Jul 14, 2022
ghost
mentioned this pull request
Merged
|
@ayanamidev This branch is out-of-date with the base branch |
|
@jdevcs @nazarhussain @luu-alex Rebased. |
jdevcs
approved these changes
Jul 19, 2022
16 tasks
jdevcs
added a commit
that referenced
this pull request
Jul 19, 2022
…5264) * Fixed unit tests & removed dead code for web3-providers-http (#5228) * Fixed unit tests & removed dead code for web3-providers-http * Use chai-as-promised to resolve or reject promise * Fixed bug that timeout option doesn't work properly * change log update Co-authored-by: Ayanami <ayanami0330@protonmail.com>
|
Merged via #5264 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5235, Fixes #5236
Description
Use fetch-mock to run unit tests against
web3-providers-httpand removed some dead code forweb3-providers-http.Also fixed issue #5235 that timeout option being ignored.
Type of change
Checklist:
npm run dtslintwith success and extended the tests and types if necessary.npm run test:covand my test cases cover all the lines and branches of the added code.npm run buildwith success.dist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.