EIP-1193 providers #5683
Merged
EIP-1193 providers #5683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://atweb3js-docs-pr-5683.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-ce79b06n6mphhrp7ad00. |
jdevcs
reviewed
Dec 6, 2022
|
Thanks @avkos good work |
avkos
requested review from
jdevcs,
nikoulai,
Muhammad-Altabba,
luu-alex and
spacesailor24
nikoulai
approved these changes
Dec 13, 2022
jdevcs
reviewed
Dec 15, 2022
There was a problem hiding this comment.
https://github.com/web3/web3.js/actions/runs/3700485520/jobs/6269015383#step:4:609. should be investigated as discussed.
|
I've created a separate task to investigate the stuck problem #5730 |
|
@avkos Please also add changelog in packages and also in root. Thanks |
|
PR LGTM |
github-actions
bot
temporarily deployed
to
Preview: (ok/4656-IPC-provider-subscription-randomly-not-working)
Deploying with
|
| Latest commit: |
cc45ff6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7d82ba38.web3-js-docs.pages.dev |
| Branch Preview URL: | https://ok-4656-ipc-provider-subscri.web3-js-docs.pages.dev |
jdevcs
approved these changes
Jan 10, 2023
github-actions
bot
temporarily deployed
to
Preview: (ok/4656-IPC-provider-subscription-randomly-not-working)
avkos
deleted the
ok/4656-IPC-provider-subscription-randomly-not-working
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
implementation of WS provider
#4656
#5460
Type of change
Checklist for 4.x:
yarnsuccessfullyyarn lintsuccessfullyyarn build:websuccessfullyyarn test:unitsuccessfullyyarn test:integrationsuccessfullycompile:contractssuccessfullyCHANGELOG.mdfile in the packages I have edited.