transaction integration tests #6071
Conversation
| @@ -220,15 +218,6 @@ export async function defaultTransactionBuilder<ReturnType = Transaction>(option | |||
| populatedTransaction.accessList = []; | |||
| } | |||
|
|
|||
| populatedTransaction = { | |||
There was a problem hiding this comment.
gas price is already assigned in sendTransaction and at this place its called again
Deploying with
|
| Latest commit: |
7168920
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e7b52b70.web3-js-docs.pages.dev |
| Branch Preview URL: | https://junaid-4xtxtests.web3-js-docs.pages.dev |
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
|
This PR is blocked due to bug : #6065 once second auto gas filling function call is not called for sendTransaction, in CI many tests are not passing : |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6071 +/- ##
==========================================
- Coverage 87.41% 87.40% -0.01%
==========================================
Files 199 199
Lines 7614 7616 +2
Branches 2065 2067 +2
==========================================
+ Hits 6656 6657 +1
- Misses 958 959 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| @@ -77,8 +77,12 @@ describe('web3.accounts', () => { | |||
| }), | |||
| ).resolves.toBeDefined(); | |||
|
|
|||
| const txWithGas = { | |||
| ...tx, | |||
| gasPrice: '0x271000', | |||
There was a problem hiding this comment.
added gasPrice explicitly in tests of this file, because now signTransaction will not fill gas price and validation fails if no gasprice or gas0x2 params are provided .
| }); | ||
| }; | ||
|
|
||
| return web3.eth.sendTransaction(txObj, undefined, { checkRevertBeforeSending: false }); |
There was a problem hiding this comment.
use internal signing, as sendTransaction auto fills gas price if not provided,
jdevcs
requested review from
avkos,
luu-alex,
Muhammad-Altabba,
nikoulai and
spacesailor24
as code owners
Description
#6013
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.