fix!: remove non read-only ens methods #6084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6084 +/- ##
==========================================
- Coverage 87.40% 87.35% -0.06%
==========================================
Files 199 197 -2
Lines 7616 7534 -82
Branches 2067 2052 -15
==========================================
- Hits 6657 6581 -76
+ Misses 959 953 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Deploying with
|
| Latest commit: |
c47f89e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6d7ee416.web3-js-docs.pages.dev |
| Branch Preview URL: | https://fix---remove-extra-ens-metho.web3-js-docs.pages.dev |
mpetrunic
requested review from
avkos,
jdevcs,
luu-alex,
Muhammad-Altabba,
nikoulai and
spacesailor24
as code owners
Signed-off-by: Marin Petrunic <marin.petrunic@gmail.com>
Signed-off-by: Marin Petrunic <marin.petrunic@gmail.com>
mpetrunic
force-pushed
the
fix!--remove-extra-ens-methods
branch
from
25414ea
to
1f865ad
Compare
avkos
requested changes
May 15, 2023
jdevcs
reviewed
May 19, 2023
| @@ -48,23 +47,6 @@ export class Registry { | |||
| } | |||
| } | |||
|
|
|||
| public setOwner( | |||
There was a problem hiding this comment.
As these are breaking changes so if you have time this should be mentioned in same PR in migration guide ? or we can add in some other PR?
jdevcs
approved these changes
May 19, 2023
Can somebody else spin them locally? For me they are passing locally :/ |
Closed
Closed
luu-alex
approved these changes
May 25, 2023
avkos
approved these changes
May 25, 2023
luu-alex
approved these changes
May 29, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Fixes #6096
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.