Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Providers Tutorial #6095

Merged
merged 18 commits into from
May 30, 2023
Merged

Providers Tutorial #6095

merged 18 commits into from
May 30, 2023

Conversation

Muhammad-Altabba
Copy link
Contributor

Description

Closes #6076

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

@Muhammad-Altabba Muhammad-Altabba linked an issue May 15, 2023 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented May 15, 2023

Bundle Stats

Hey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Asset Old size New size Diff Diff %
Total 645 KB 645 KB 0 0.00%
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset Old size New size Diff Diff %
web3.min.js 628 KB 628 KB 0 0.00%
../lib/commonjs/index.d.ts 8.43 KB 8.43 KB 0 0.00%
../lib/commonjs/accounts.d.ts 3.67 KB 3.67 KB 0 0.00%
../lib/commonjs/types.d.ts 2.37 KB 2.37 KB 0 0.00%
../lib/commonjs/abi.d.ts 1000 bytes 1000 bytes 0 0.00%
../lib/commonjs/web3.d.ts 808 bytes 808 bytes 0 0.00%
../lib/commonjs/eth.exports.d.ts 280 bytes 280 bytes 0 0.00%
../lib/commonjs/providers.exports.d.ts 148 bytes 148 bytes 0 0.00%
../lib/commonjs/version.d.ts 60 bytes 60 bytes 0 0.00%

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #6095 (6e2242d) into 4.x (bf1311f) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #6095   +/-   ##
=======================================
  Coverage   87.41%   87.41%           
=======================================
  Files         199      199           
  Lines        7614     7614           
  Branches     2065     2065           
=======================================
  Hits         6656     6656           
  Misses        958      958           
Flag Coverage Δ
UnitTests 87.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

@cloudflare-pages
Copy link

cloudflare-pages bot commented May 16, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6e2242d
Status: ✅  Deploy successful!
Preview URL: https://f482fe49.web3-js-docs.pages.dev
Branch Preview URL: https://6076-providers-tutorial.web3-js-docs.pages.dev

View logs

@jdevcs
Copy link
Contributor

jdevcs commented May 16, 2023

Thanks @Muhammad-Altabba for your contribution.

@djrann13 djrann13 linked an issue May 20, 2023 that may be closed by this pull request
This was unlinked from issues May 20, 2023
docs/docs/tutorials/providers.md Show resolved Hide resolved
docs/docs/tutorials/providers.md Outdated Show resolved Hide resolved
docs/docs/tutorials/providers.md Outdated Show resolved Hide resolved
docs/docs/tutorials/providers.md Outdated Show resolved Hide resolved
docs/docs/tutorials/providers.md Outdated Show resolved Hide resolved
docs/docs/tutorials/providers.md Show resolved Hide resolved
docs/docs/tutorials/providers.md Outdated Show resolved Hide resolved
docs/docs/tutorials/providers.md Outdated Show resolved Hide resolved
docs/docs/tutorials/providers.md Outdated Show resolved Hide resolved
Comment on lines +128 to +129

### WebSocket Provider
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### WebSocket Provider
This example showed how to connect to the Ethereum network using HTTP provider, get the current block number, send a transaction, and get the updated block number.
### WebSocket Provider

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You had this block of text before, but I think it got mistakenly removed with the edits

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I removed it as it is a repetition of what is mentioned here:

To connect to the Ethereum network using the HTTP provider, follow these steps:

And here:

If everything is set up properly, you should see the current block number, the transaction receipt, and the updated block number printed in the console:

Thanks,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Providers Tutorial
5 participants