Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Canary releases #6143

Merged
merged 8 commits into from
Jun 2, 2023
Merged

Canary releases #6143

merged 8 commits into from
Jun 2, 2023

Conversation

mpetrunic
Copy link
Contributor

Description

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

@mpetrunic
update lerna
c6e179e 
Signed-off-by: Marin Petrunic <marin.petrunic@gmail.com>
@mpetrunic
add canary release flow
2d75307
@mpetrunic
Copy link
Contributor Author

@jdevcs This needs NPM_TOKEN secret with npm registry automation token^^

@github-actions
Copy link

github-actions bot commented Jun 1, 2023

Bundle Stats

Hey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Asset Old size New size Diff Diff %
Total 638 KB 638 KB 0 0.00%
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset Old size New size Diff Diff %
web3.min.js 621 KB 621 KB 0 0.00%
../lib/commonjs/index.d.ts 8.44 KB 8.44 KB 0 0.00%
../lib/commonjs/accounts.d.ts 3.67 KB 3.67 KB 0 0.00%
../lib/commonjs/types.d.ts 2.37 KB 2.37 KB 0 0.00%
../lib/commonjs/abi.d.ts 1000 bytes 1000 bytes 0 0.00%
../lib/commonjs/web3.d.ts 811 bytes 811 bytes 0 0.00%
../lib/commonjs/eth.exports.d.ts 280 bytes 280 bytes 0 0.00%
../lib/commonjs/providers.exports.d.ts 148 bytes 148 bytes 0 0.00%
../lib/commonjs/version.d.ts 60 bytes 60 bytes 0 0.00%

@cloudflare-pages
Copy link

cloudflare-pages bot commented Jun 1, 2023 •
edited

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: d71df33
Status: ✅  Deploy successful!
Preview URL: https://886b3d3f.web3-js-docs.pages.dev
Branch Preview URL: https://canary-releases.web3-js-docs.pages.dev

View logs

@codecov
Copy link

codecov bot commented Jun 1, 2023 •
edited

Codecov Report

Merging #6143 (d71df33) into 4.x (01ce365) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##              4.x    #6143   +/-   ##
=======================================
  Coverage   87.37%   87.37%           
=======================================
  Files         197      197           
  Lines        7548     7548           
  Branches     2059     2059           
=======================================
  Hits         6595     6595           
  Misses        953      953
Flag Coverage Δ
UnitTests 87.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

@Muhammad-Altabba
Copy link
Contributor

Thank you for your great contribution @mpetrunic,
Do you think we can provide an automatic incremental build number for each canary version? For example, [major].[minor].[batch]-dev.[buildnumber]? Or if not incremental build number is to use data-time, for example?
The idea if we want to test with a specific build, it would be easy to provide the exact version of that package. Or what do you think?

jdevcs
jdevcs reviewed Jun 2, 2023
View reviewed changes
package.json Outdated
@@ -91,7 +91,8 @@
"test:blackbox:infura:ws": "yarn pre-blackbox && ./scripts/verdaccio.sh startBackgroundAndPublish && lerna run test:blackbox:infura:ws --stream && yarn post-blackbox",
"prepare": "husky install",
"postinstall": "yarn build",
"compile:contracts": "node ./scripts/compile_contracts.js && yarn format && yarn lint:fix"
"compile:contracts": "node ./scripts/compile_contracts.js && yarn format && yarn lint:fix",
"publish:canary": "lerna --canary --dist-tag dev --graph-type all --no-verify-access --yes"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution Marin,
if we dnt increment version # this will override existing dist version in npm, or will not able to push?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, so it will publish current [version].[commitsha] and it will tag that version with "dev" tag. It will never generate same version twice.

@mpetrunic
Copy link
Contributor Author

Thank you for your great contribution @mpetrunic, Do you think we can provide an automatic incremental build number for each canary version? For example, [major].[minor].[batch]-dev.[buildnumber]? Or if not incremental build number is to use data-time, for example? The idea if we want to test with a specific build, it would be easy to provide the exact version of that package. Or what do you think?

This will attach short commit sha to the version and it will put npm tag "dev" to the npm registry so you can either install with npm i web3@4.0.1-alpha.ce6t2s+2ob4 or npm i web3@dev.

jdevcs
jdevcs approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@jdevcs jdevcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just shared few discussion points, lgtm, Thanks Marin

@mpetrunic
add type building
be979c8 
Signed-off-by: Marin Petrunic <marin.petrunic@gmail.com>
@mpetrunic
Copy link
Contributor Author

@jdevcs This needs NPM_TOKEN secret with npm registry automation token^^

Done

@mpetrunic
add force publish all
ad525cf 
Signed-off-by: Marin Petrunic <marin.petrunic@gmail.com>
@mpetrunic
add missing publish
7de986a 
Signed-off-by: Marin Petrunic <marin.petrunic@gmail.com>
avkos
avkos requested changes Jun 2, 2023
View reviewed changes
.github/workflows/canary_release.yml Outdated Show resolved Hide resolved
@avkos avkos self-requested a review June 2, 2023 12:50
@jdevcs jdevcs merged commit 45edf3d into 4.x Jun 2, 2023
64 of 67 checks passed
@jdevcs jdevcs deleted the canary-releases branch June 2, 2023 13:44
@NaughtyUnicorn24 NaughtyUnicorn24 mentioned this pull request Mar 24, 2024
Open
@vutting4221 vutting4221 mentioned this pull request Mar 24, 2024
Open
@PinkDiamond1 PinkDiamond1 mentioned this pull request Mar 24, 2024
Open
@affiliatedkat affiliatedkat mentioned this pull request Mar 24, 2024
Open
@internetbuilder internetbuilder mentioned this pull request Mar 25, 2024
Open
@baby636 baby636 mentioned this pull request Mar 25, 2024
Open
@awaisab172 awaisab172 mentioned this pull request Apr 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avkos avkos avkos approved these changes

@Muhammad-Altabba Muhammad-Altabba Muhammad-Altabba approved these changes

@luu-alex luu-alex luu-alex approved these changes

@jdevcs jdevcs jdevcs approved these changes

@spacesailor24 spacesailor24 Awaiting requested review from spacesailor24

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mpetrunic @Muhammad-Altabba @avkos @luu-alex @jdevcs