Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for ABI encoding large negative ints #6239

Merged
merged 11 commits into from
Jun 29, 2023
Merged

Fix for ABI encoding large negative ints #6239

merged 11 commits into from
Jun 29, 2023

Conversation

spacesailor24
Copy link
Contributor

closes #5890

@spacesailor24 spacesailor24 added the 1.x 1.0 related issues label Jun 28, 2023
@spacesailor24 spacesailor24 self-assigned this Jun 28, 2023
@spacesailor24 spacesailor24 changed the base branch from 4.x to 1.x June 28, 2023 01:25
@spacesailor24 spacesailor24 mentioned this pull request Jun 28, 2023
Closed
1 task
@spacesailor24 spacesailor24 force-pushed the wyatt/1.x/5890-abi-encoding-ints branch from 7105823 to f2f7c55 Compare June 28, 2023 01:31
@github-actions
Copy link

github-actions bot commented Jun 28, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5406295791

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 273 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+2.4%) to 75.146%
Files with Coverage Reduction New Missed Lines %
packages/web3-core-requestmanager/src/jsonrpc.js 2 64.29%
packages/web3-core-helpers/src/formatters.js 9 83.86%
packages/web3-core-helpers/src/errors.js 31 1.47%
packages/web3-utils/src/soliditySha3.js 34 3.43%
packages/web3-utils/src/index.js 40 40.3%
packages/web3-utils/src/utils.js 46 10.39%
packages/web3-eth-accounts/src/index.js 111 22.94%
Totals Coverage Status
Change from base Build 5406098199: 2.4%
Covered Lines: 3353
Relevant Lines: 4212
💛 - Coveralls

@spacesailor24 spacesailor24 marked this pull request as ready for review June 28, 2023 04:17
@spacesailor24 spacesailor24 merged commit 47b9769 into 1.x Jun 29, 2023
12 of 13 checks passed
@spacesailor24 spacesailor24 deleted the wyatt/1.x/5890-abi-encoding-ints branch June 29, 2023 19:21
@jdevcs jdevcs mentioned this pull request Aug 2, 2023
Merged
This was referenced Sep 4, 2023
Open
Open
This was referenced May 12, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced May 22, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avkos avkos avkos approved these changes

@luu-alex luu-alex luu-alex approved these changes

@jdevcs jdevcs jdevcs approved these changes

@Muhammad-Altabba Muhammad-Altabba Awaiting requested review from Muhammad-Altabba Muhammad-Altabba is a code owner

Assignees

@spacesailor24 spacesailor24

Labels
1.x 1.0 related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Negative large numbers throw exceptions when passed to encodeFunctionCall
4 participants
@spacesailor24 @avkos @luu-alex @jdevcs