Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eth personal in web3.eth #6245

Merged
merged 3 commits into from
Jul 3, 2023
Merged

Eth personal in web3.eth #6245

merged 3 commits into from
Jul 3, 2023

Conversation

jdevcs
Copy link
Contributor

@jdevcs jdevcs commented Jun 29, 2023

Description

#6236

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

@jdevcs jdevcs added the 4.x 4.0 related label Jun 29, 2023
@github-actions
Copy link

github-actions bot commented Jun 29, 2023

Bundle Stats

Hey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Asset Old size New size Diff Diff %
Total 640 KB 640 KB 74 bytes 0.01%
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset Old size New size Diff Diff %
web3.min.js 623 KB 623 KB 0 0.00%
../lib/commonjs/index.d.ts 8.56 KB 8.56 KB 0 0.00%
../lib/commonjs/accounts.d.ts 3.67 KB 3.67 KB 0 0.00%
../lib/commonjs/types.d.ts 2.37 KB 2.45 KB 74 bytes 3.04%
../lib/commonjs/abi.d.ts 1000 bytes 1000 bytes 0 0.00%
../lib/commonjs/web3.d.ts 811 bytes 811 bytes 0 0.00%
../lib/commonjs/eth.exports.d.ts 280 bytes 280 bytes 0 0.00%
../lib/commonjs/providers.exports.d.ts 148 bytes 148 bytes 0 0.00%
../lib/commonjs/version.d.ts 60 bytes 60 bytes 0 0.00%

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #6245 (59a20da) into 4.x (d12dc7e) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #6245   +/-   ##
=======================================
  Coverage   87.62%   87.62%           
=======================================
  Files         197      197           
  Lines        7601     7601           
  Branches     2083     2083           
=======================================
  Hits         6660     6660           
  Misses        941      941           
Flag Coverage Δ
UnitTests 87.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

@cloudflare-pages
Copy link

cloudflare-pages bot commented Jun 29, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 59a20da
Status: ✅  Deploy successful!
Preview URL: https://e3052e9d.web3-js-docs.pages.dev
Branch Preview URL: https://junaid-6236ethpersonal4x.web3-js-docs.pages.dev

View logs

Copy link
Contributor

@Muhammad-Altabba Muhammad-Altabba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just a tiny suggestion.
Thanks,

packages/web3/src/types.ts Outdated Show resolved Hide resolved
Co-authored-by: Muhammad Altabba <24407834+Muhammad-Altabba@users.noreply.github.com>
@jdevcs jdevcs merged commit 602dada into 4.x Jul 3, 2023
66 of 67 checks passed
@jdevcs jdevcs deleted the junaid/6236ethpersonal4x branch July 3, 2023 10:30
@jdevcs jdevcs mentioned this pull request Jul 10, 2023
sanyu1225 pushed a commit to blocto/web3.js that referenced this pull request Aug 30, 2023
* added eth personal type in web3.eth

* changelog update

* Update packages/web3/src/types.ts

Co-authored-by: Muhammad Altabba <24407834+Muhammad-Altabba@users.noreply.github.com>

---------

Co-authored-by: Muhammad Altabba <24407834+Muhammad-Altabba@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x 4.0 related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants