-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #6439: ensure provider.supportsSubscriptions
exists before watching by subscription
#6440
Conversation
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Deploying with
|
Latest commit: |
e1ddefb
|
Status: | ✅ Deploy successful! |
Preview URL: | https://8c6cad3f.web3-js-docs.pages.dev |
Branch Preview URL: | https://6439-error-when-ganache-is-i.web3-js-docs.pages.dev |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6440 +/- ##
=======================================
Coverage 89.15% 89.15%
=======================================
Files 199 199
Lines 7756 7756
Branches 2147 2147
=======================================
Hits 6915 6915
Misses 841 841
Flags with carried forward coverage won't be shown. Click here to find out more.
|
provider.supportsSubscriptions
exist before watching by subscriptionprovider.supportsSubscriptions
exists before watching by subscription
…ider-typeerror-providersupportssubscriptions-is-not-a-function
Description
Fixes #6439
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.