Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Unit test coverage for web3-eth above 90% #6663

Merged
merged 9 commits into from Jan 3, 2024

Conversation

Muhammad-Altabba
Copy link
Contributor

@Muhammad-Altabba Muhammad-Altabba commented Dec 13, 2023

Description

Fixes #6566

Also it fix issues with composing transaction config. However, it seems to need more on this. And a follow up issue was created in this regard: #6666

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

@Muhammad-Altabba Muhammad-Altabba linked an issue Dec 13, 2023 that may be closed by this pull request
Copy link

github-actions bot commented Dec 13, 2023

Bundle Stats

Hey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Asset Old size New size Diff Diff %
Total 0 591 KB 591 KB -
View detailed bundle breakdown

Added

Asset Old size New size Diff Diff %
web3.min.js 0 573 KB 573 KB -
../lib/commonjs/index.d.ts 0 8.63 KB 8.63 KB -
../lib/commonjs/accounts.d.ts 0 3.89 KB 3.89 KB -
../lib/commonjs/types.d.ts 0 2.45 KB 2.45 KB -
../lib/commonjs/web3.d.ts 0 1.14 KB 1.14 KB -
../lib/commonjs/abi.d.ts 0 999 bytes 999 bytes -
../lib/commonjs/eth.exports.d.ts 0 280 bytes 280 bytes -
../lib/commonjs/providers.exports.d.ts 0 148 bytes 148 bytes -
../lib/commonjs/version.d.ts 0 60 bytes 60 bytes -

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

No assets were unchanged

Copy link

cloudflare-pages bot commented Dec 13, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 97cc1b5
Status: ✅  Deploy successful!
Preview URL: https://afa36341.web3-js-docs.pages.dev
Branch Preview URL: https://6566-increase-web3-eth-unit.web3-js-docs.pages.dev

View logs

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Merging #6663 (97cc1b5) into 4.x (4358140) will increase coverage by 4.09%.
Report is 138 commits behind head on 4.x.
The diff coverage is 93.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##              4.x    #6663      +/-   ##
==========================================
+ Coverage   87.37%   91.46%   +4.09%     
==========================================
  Files         197      214      +17     
  Lines        7548     8155     +607     
  Branches     2059     2193     +134     
==========================================
+ Hits         6595     7459     +864     
+ Misses        953      696     -257     
Flag Coverage Δ
UnitTests 91.46% <93.65%> (+4.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

@Muhammad-Altabba Muhammad-Altabba changed the title [DRAFT] fix issues in Common config and add a test to accounts Increase Unit test coverage for web3-eth above 90% Dec 15, 2023
@Muhammad-Altabba Muhammad-Altabba marked this pull request as ready for review December 15, 2023 15:55
Copy link

Benchmark

Benchmark suite Current: e6076e6 Previous: 6b2dbe3 Ratio
processingTx 9351 ops/sec (±3.86%) 9461 ops/sec (±3.80%) 1.01
processingContractDeploy 37807 ops/sec (±8.59%) 39953 ops/sec (±8.59%) 1.06
processingContractMethodSend 19538 ops/sec (±4.60%) 19674 ops/sec (±7.66%) 1.01
processingContractMethodCall 39062 ops/sec (±4.35%) 40398 ops/sec (±6.04%) 1.03
abiEncode 42593 ops/sec (±8.78%) 45689 ops/sec (±7.26%) 1.07
abiDecode 31557 ops/sec (±6.40%) 30825 ops/sec (±8.59%) 0.98
sign 1593 ops/sec (±5.26%) 1617 ops/sec (±3.77%) 1.02
verify 373 ops/sec (±0.63%) 379 ops/sec (±0.57%) 1.02

This comment was automatically generated by workflow using github-action-benchmark.

undefined,
chainId: common.chainId
? common.chainId()
: BigInt((common as unknown as CommonType).customChain?.chainId) ??
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be in changelog?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase Web3-eth Unit tests above 90%
3 participants