Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update transactions.md #6783

Merged
merged 3 commits into from Feb 5, 2024
Merged

Update transactions.md #6783

merged 3 commits into from Feb 5, 2024

Conversation

jasonaw98
Copy link
Contributor

@jasonaw98 jasonaw98 commented Feb 2, 2024

Made some changes on the Transaction Object for sending raw transactions. The current tx object will result in an error when calling web3.eth.sendSignedTransaction

Description

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

Made some changes on the Transaction Object for sending raw transactions. The current tx object will result in an error when calling web3.eth.sendSignedTransaction
@SantiagoDevRel
Copy link
Member

Issue #6786

Co-authored-by: Alex  <luu.alex98@gmail.com>
@SantiagoDevRel SantiagoDevRel merged commit a6b685e into web3:4.x Feb 5, 2024
11 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants