Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show warning for ambiguous Solidity method call #6942

Merged
merged 6 commits into from
Mar 29, 2024

Conversation

Muhammad-Altabba
Copy link
Contributor

Description

Fixes #6650

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

@Muhammad-Altabba Muhammad-Altabba linked an issue Mar 27, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Mar 27, 2024

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 619.46 kB → 619.77 kB (+316 B) +0.05%
Changeset
File Δ Size
../web3-eth-contract/lib/commonjs/contract.js 📈 +509 B (+1.27%) 39.2 kB → 39.7 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
web3.min.js 600.39 kB → 600.7 kB (+316 B) +0.05%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
../lib/commonjs/index.d.ts 8.69 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.45 kB 0%
../lib/commonjs/web3.d.ts 1.35 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.2 kB 0%
../lib/commonjs/abi.d.ts 999 B 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

github-actions bot commented Mar 27, 2024

Benchmark

Benchmark suite Current: baf686d Previous: 6c075db Ratio
processingTx 9359 ops/sec (±4.30%) 9301 ops/sec (±4.81%) 0.99
processingContractDeploy 38971 ops/sec (±6.87%) 39129 ops/sec (±7.62%) 1.00
processingContractMethodSend 19087 ops/sec (±5.21%) 19443 ops/sec (±5.19%) 1.02
processingContractMethodCall 38515 ops/sec (±5.91%) 38971 ops/sec (±6.34%) 1.01
abiEncode 44216 ops/sec (±8.28%) 44252 ops/sec (±6.92%) 1.00
abiDecode 31472 ops/sec (±6.43%) 30419 ops/sec (±8.89%) 0.97
sign 1591 ops/sec (±3.53%) 1656 ops/sec (±4.08%) 1.04
verify 376 ops/sec (±0.57%) 373 ops/sec (±0.78%) 0.99

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Merging #6942 (baf686d) into 4.x (526c6f5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #6942   +/-   ##
=======================================
  Coverage   91.96%   91.96%           
=======================================
  Files         215      215           
  Lines        8197     8200    +3     
  Branches     2214     2214           
=======================================
+ Hits         7538     7541    +3     
  Misses        659      659           
Flag Coverage Δ
UnitTests 91.96% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

Copy link
Contributor

@jdevcs jdevcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, requested few small changes before merging.thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

contract method override types issues
3 participants