Add contract.decodeMethodData(...) method to decode contract methods and to contract.deploy(...).decodeData(...) decode constructor parameters
#6950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: 27da7ac | Previous: 6c075db | Ratio |
|---|---|---|---|
processingTx |
9541 ops/sec (±3.47%) |
9301 ops/sec (±4.81%) |
0.97 |
processingContractDeploy |
41153 ops/sec (±6.69%) |
39129 ops/sec (±7.62%) |
0.95 |
processingContractMethodSend |
19950 ops/sec (±7.38%) |
19443 ops/sec (±5.19%) |
0.97 |
processingContractMethodCall |
40676 ops/sec (±6.80%) |
38971 ops/sec (±6.34%) |
0.96 |
abiEncode |
43381 ops/sec (±7.33%) |
44252 ops/sec (±6.92%) |
1.02 |
abiDecode |
31312 ops/sec (±7.64%) |
30419 ops/sec (±8.89%) |
0.97 |
sign |
1612 ops/sec (±3.32%) |
1656 ops/sec (±4.08%) |
1.03 |
verify |
388 ops/sec (±0.36%) |
373 ops/sec (±0.78%) |
0.96 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6950 +/- ##
==========================================
+ Coverage 87.37% 91.95% +4.57%
==========================================
Files 197 215 +18
Lines 7548 8212 +664
Branches 2059 2214 +155
==========================================
+ Hits 6595 7551 +956
+ Misses 953 661 -292
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Muhammad-Altabba
changed the title
contract.decodeMethodData(...) method to decode contract methods and to contract.deploy(...).decodeData(...) decode constructor parameters
Muhammad-Altabba
requested review from
avkos,
jdevcs and
luu-alex
as code owners
17 tasks
jdevcs
reviewed
Apr 5, 2024
| @@ -964,6 +965,21 @@ export class Contract<Abi extends ContractAbi> | |||
| : value; | |||
| } | |||
|
|
|||
| public decodeMethodData(data: HexString): DecodedParams & { __method__: string } { | |||
There was a problem hiding this comment.
pls add this in docs under generated methods
like https://docs.web3js.org/libdocs/Contract#generated-methodsThanks
jdevcs
approved these changes
Apr 5, 2024
avkos
approved these changes
Apr 5, 2024
Muhammad-Altabba
deleted the
6220-add-method-decodeabi-to-method-interface
branch
Merged
This was referenced May 26, 2024
This was referenced Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6220
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.