Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coverage increase #7051

Merged
merged 4 commits into from
May 24, 2024
Merged

coverage increase #7051

merged 4 commits into from
May 24, 2024

Conversation

jdevcs
Copy link
Contributor

@jdevcs jdevcs commented May 21, 2024

Description

#7032

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

Copy link

github-actions bot commented May 21, 2024

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 624.38 kB → 625.57 kB (+1.19 kB) +0.19%
Changeset
File Δ Size
../web3-utils/lib/commonjs/formatter.js 📈 +1.08 kB (+9.02%) 12.02 kB → 13.11 kB
../web3-eth/lib/commonjs/utils/get_transaction_gas_pricing.js 📈 +404 B (+8.70%) 4.53 kB → 4.93 kB
../web3-errors/lib/commonjs/errors/utils_errors.js 📈 +317 B (+6.21%) 4.98 kB → 5.29 kB
../web3-eth/lib/commonjs/utils/send_tx_helper.js 📈 +418 B (+4.74%) 8.6 kB → 9.01 kB
../web3-utils/lib/commonjs/converters.js 📈 +433 B (+2.04%) 20.76 kB → 21.18 kB
../web3-validator/lib/commonjs/validation/numbers.js 📈 +79 B (+1.84%) 4.2 kB → 4.28 kB
../web3-errors/lib/commonjs/error_codes.js 📈 +66 B (+0.62%) 10.38 kB → 10.45 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
web3.min.js 605.08 kB → 606.28 kB (+1.19 kB) +0.20%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
../lib/commonjs/index.d.ts 8.69 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.67 kB 0%
../lib/commonjs/web3.d.ts 1.35 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.2 kB 0%
../lib/commonjs/abi.d.ts 999 B 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 19602ab Previous: f4e55bd Ratio
processingTx 8890 ops/sec (±4.02%) 9157 ops/sec (±3.53%) 1.03
processingContractDeploy 39552 ops/sec (±6.70%) 39854 ops/sec (±6.49%) 1.01
processingContractMethodSend 18468 ops/sec (±8.65%) 19031 ops/sec (±8.97%) 1.03
processingContractMethodCall 37510 ops/sec (±5.77%) 37579 ops/sec (±6.24%) 1.00
abiEncode 42293 ops/sec (±6.73%) 42781 ops/sec (±6.77%) 1.01
abiDecode 29068 ops/sec (±8.33%) 29806 ops/sec (±7.94%) 1.03
sign 1541 ops/sec (±0.64%) 1522 ops/sec (±3.29%) 0.99
verify 356 ops/sec (±2.71%) 368 ops/sec (±0.73%) 1.03

This comment was automatically generated by workflow using github-action-benchmark.

Copy link
Contributor

@avkos avkos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. please fix Github Actions

Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.21%. Comparing base (2f73aa5) to head (19602ab).
Report is 6 commits behind head on 4.x.

Additional details and impacted files
@@            Coverage Diff             @@
##              4.x    #7051      +/-   ##
==========================================
+ Coverage   91.97%   92.21%   +0.24%     
==========================================
  Files         215      215              
  Lines        8291     8329      +38     
  Branches     2277     2296      +19     
==========================================
+ Hits         7626     7681      +55     
+ Misses        665      648      -17     
Flag Coverage Δ
UnitTests 92.21% <ø> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

@jdevcs jdevcs merged commit 692987a into 4.x May 24, 2024
53 checks passed
@jdevcs jdevcs deleted the junaid/rpcmethodstests branch May 24, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants