Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Quorum Extension APIs #68

Merged
merged 2 commits into from
Dec 19, 2022

Conversation

krishnan-narayanan-partior
Copy link
Contributor

What does this PR do?

Adds support for Quorum Extension APIs

New API methods

  • quorumExtension_activeExtensionContracts
  • quorumExtension_approveExtension
  • quorumExtension_cancelExtension
  • quorumExtension_extendContract
  • quorumExtension_getExtensionStatus

Where should the reviewer start?

New functions added to Quorum.java and JsonRpc2_0Quorum.java
New Response types added

Why is it needed?

Contract Extension is a primary use case to extend smart contracts when new nodes join the network. DApps require web3j-quorum to support this functionality

@krishnan-narayanan-partior krishnan-narayanan-partior marked this pull request as ready for review November 20, 2022 16:54
@krishnan-narayanan-partior krishnan-narayanan-partior marked this pull request as draft November 21, 2022 02:03
@krishnan-narayanan-partior krishnan-narayanan-partior marked this pull request as ready for review November 28, 2022 05:22
@krsh24
Copy link

krsh24 commented Nov 30, 2022

@conor10 and @iikirilov can I please kindly ask you to review this change?

Copy link
Contributor

@nicolae-leonte-go nicolae-leonte-go left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@gtebrean gtebrean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicely done!

@gtebrean gtebrean merged commit f691680 into web3j:master Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants