Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource conflict with other libraries #365

Closed
liorregev opened this issue Feb 15, 2018 · 2 comments
Closed

Resource conflict with other libraries #365

liorregev opened this issue Feb 15, 2018 · 2 comments
Labels
bug A bug in behaviour or functionality

Comments

@liorregev
Copy link

I believe you should avoid having resources in the root of the 'resources' directory since it is not specific to you library and a class-loader could fetch the wrong one if multiple libraries do this.

For example: your 'version.properties' resource conflict with the one in https://github.com/ethereum/ethereumj and therefore causes NullPointerException
I have opened a similar issue on that repo, but I think it should be fixed in both

@iikirilov
Copy link
Contributor

Thanks for bringing up this issue. It was resolved in ethereumj with this commit.
@conor10 any other thoughts on this?

@iikirilov iikirilov added the bug A bug in behaviour or functionality label Feb 23, 2018
@fcorneli
Copy link
Contributor

Maybe rename "version.properties" to "web3j-version.properties" to prevent conflicts with yet other libraries too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug in behaviour or functionality
Projects
None yet
Development

No branches or pull requests

4 participants