Code generator correction #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xaviarias
approved these changes
Sep 18, 2018
This was referenced Sep 19, 2018
iikirilov
approved these changes
Sep 30, 2018
conor10
reviewed
Oct 3, 2018
| classBuilder.addMethod(buildConstructor(TransactionManager.class, | ||
| TRANSACTION_MANAGER)); | ||
| classBuilder.addFields(buildFuncNameConstants(abi)); | ||
| classBuilder.addMethods( | ||
| buildFunctionDefinitions(className, classBuilder, abi)); | ||
| classBuilder.addMethod(buildLoad(className, Credentials.class, CREDENTIALS)); |
There was a problem hiding this comment.
We should be able to provide a TransactionManager or Credentials in a generated class - this looks like it removes the credentials.
There was a problem hiding this comment.
Let me roll back this commit and get the 3.6 out, given that more work needs to be done on this.
|
cherry-picked this commit and applied comment in #725 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
both of these changes introduce the ContractGasProvider in the generated
code
Where should the reviewer start?
Why is it needed?