731: Fix NPE in WebSocketClient if an error occurs during connection #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snazha-blkio
changed the title
iikirilov
approved these changes
Nov 13, 2018
|
Although WebSocketClientTest.java already tests the functionality I added a dedicated test for the case where the listener is not set. |
…fix/731-npe-websocket-client
# Conflicts:
# core/src/main/java/org/web3j/protocol/websocket/WebSocketClient.java
iikirilov
reviewed
Nov 13, 2018
Codecov Report
@@ Coverage Diff @@
## release/4.0 #783 +/- ##
=================================================
+ Coverage 77.24% 77.25% +0.01%
- Complexity 1849 1850 +1
=================================================
Files 241 241
Lines 6815 6818 +3
Branches 1012 1012
=================================================
+ Hits 5264 5267 +3
Misses 1301 1301
Partials 250 250
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Addresses the case where WebSocketClient is used without a listener.
Where should the reviewer start?
WebSocketClient.
Why is it needed?
To safeguard against NPEs, and to address an issue raised via another PR: #731