Better verbosity settings #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 28, 2018 17:15
This allows users to understand the logging levels and how they correspond to verbosity levels without reading the source code.
Before this change, a user specifying a verbosity > 3 would not hit any case in the verbosity switch statement, and the Go zero-valued default would result in FATAL level logs only. This is unlikely to be their intention. This change will cause the log level to default to DEBUG, which is likely what a user specifying a high verbosity wants. A user who does not specify a default will still get WARN level logging by default due to CLI defaults.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had some confusion around logging levels, mostly coming from other Go software like geth where verbosity goes up to 5 or 6. Submitting some small user experience improvements to verbosity handling that would have made my life easier.