Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid RLP #22

Closed
olegabr opened this issue May 19, 2021 · 4 comments
Closed

Invalid RLP #22

olegabr opened this issue May 19, 2021 · 4 comments

Comments

@olegabr
Copy link

olegabr commented May 19, 2021

transaction: Array
(
    [from] => 0xC14DeDeC7c21Fdd07e319Ef633606bFaaEB51F64
    [nonce] => 0xfa
    [to] => 0x1cb6138c21ac288e3e79e258d70112192c1bbdcc
    [gas] => 0x5208
    [gasPrice] => 0x0713fb3000
    [value] => 0x0de0b6b3a7640000
    [chainId] => 100
)

signedTransaction: 0xf86cfa850713fb3000825208941cb6138c21ac288e3e79e258d70112192c1bbdcc880de0b6b3a764000080eca093268b50f343ded33740d6a479a62a0e19d0ac624ba12d5fdd1056a0f91757a4a0460b277a83ee7c6a1ff81dd34d04da104d8eb6668cd84ef39880cd383ceafe22

Related to #21. Worked OK till some threshold nonce value and stopped then. xdai chain was tested in this case.

@olegabr
Copy link
Author

olegabr commented May 19, 2021

Look at this commit in my fork: olegabr@938a27a
Test mediumint4 passes, while mediumint5 and bigint fail.

  "mediumint4": {
    "in": "#83729609699884896815286331701780722",
    "out": "0x8f102030405060708090a0b0c0d0e0f2"
  },
  "mediumint5": {
    "in": "#105315505618206987246253880190783558935785933862974822347068935681",
    "out": "0x9c0100020003000400050006000700080009000a000b000c000d000e01"
  },
  "bigint": {
    "in": "#115792089237316195423570985008687907853269984665640564039457584007913129639936",
    "out": "0xa1010000000000000000000000000000000000000000000000000000000000000000"
  }

olegabr added a commit to olegabr/rlp that referenced this issue May 24, 2021
@olegabr
Copy link
Author

olegabr commented May 24, 2021

Fix: olegabr@6ac6613

@sc0Vu
Copy link
Member

sc0Vu commented Jun 4, 2021

Thanks @olegabr, I was thinking this PR might related: #19

@sc0Vu
Copy link
Member

sc0Vu commented Jun 4, 2021

I think I made a mistake in last commit, and the code base looks bad.
I'm going to rewrite this library and see how it works.

@sc0Vu sc0Vu mentioned this issue Aug 30, 2021
@sc0Vu sc0Vu closed this as completed Sep 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants