Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature BIP44(2/2) #734

Merged
merged 2 commits into from Jan 28, 2023
Merged

Feature BIP44(2/2) #734

merged 2 commits into from Jan 28, 2023

Conversation

albertopeam
Copy link
Contributor

@albertopeam albertopeam commented Jan 20, 2023 •
edited

Summary of Changes

This PR is related to #719, I have a local commit with the last changes but I forgot to push it and the branch was merged. I noticed it today.
Apologies, could you take a look @yaroslavyaroslav @JeneaVranceanu?

Test Data or Screenshots

  • I have reviewed the Contribution Guidelines.
  • I have performed a self-review of my own code.
  • I have updated my repository to match the develop branch.
  • I have included test data or screenshots that prove my fix is effective or that my feature works.
  • I have checked that all tests work and swiftlint is not throwing any errors/warnings.

@albertopeam albertopeam changed the title Add bip 44 Add bip 44(2/2) Jan 20, 2023
@albertopeam albertopeam changed the title Add bip 44(2/2) Feature BIP44(2/2) Jan 20, 2023
@yaroslavyaroslav
Copy link
Collaborator

yaroslavyaroslav commented Jan 20, 2023 •
edited

Is there anything urgent in merging this pr right now, instead of as a patch? @albertopeam

@albertopeam
Copy link
Contributor Author

albertopeam commented Jan 22, 2023 •
edited

Is there anything urgent in merging this pr right now, instead of as a patch? @albertopeam

Nop, not urgent at all. Those are improvements that you and @JeneaVranceanu requested and I didn't push since I had pending feedback to do.
Changes not pushed:

  • replace String with EthereumAddress
  • reduce line width in doc
  • improve EtherscanTransactionChecker and EtherscanTransactionCheckerTests

JeneaVranceanu
JeneaVranceanu approved these changes Jan 23, 2023
View reviewed changes
Copy link
Collaborator

@JeneaVranceanu JeneaVranceanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Nice one.

@yaroslavyaroslav yaroslavyaroslav merged commit b689a05 into web3swift-team:develop Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaroslavyaroslav yaroslavyaroslav yaroslavyaroslav approved these changes

@JeneaVranceanu JeneaVranceanu JeneaVranceanu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@albertopeam @yaroslavyaroslav @JeneaVranceanu