Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: convertToData handles Bool #750

Merged
merged 2 commits into from Feb 4, 2023
Merged

feat: convertToData handles Bool #750

merged 2 commits into from Feb 4, 2023

Conversation

JeneaVranceanu
Copy link
Collaborator

Summary of Changes

func convertToData now able to convert Bool value to 1 byte Data.
If the value is true output is 0x01 if false it's 0x00.

Test Data or Screenshots

By submitting this pull request, you are confirming the following:
  • I have reviewed the Contribution Guidelines.
  • I have performed a self-review of my own code.
  • I have updated my repository to match the develop branch.
  • I have included test data or screenshots that prove my fix is effective or that my feature works.
  • I have checked that all tests work and swiftlint is not throwing any errors/warnings.

@JeneaVranceanu JeneaVranceanu self-assigned this Feb 1, 2023
@JeneaVranceanu
Copy link
Collaborator Author

Tests will fix themselves when #725 is merged.

@yaroslavyaroslav yaroslavyaroslav dismissed their stale review February 2, 2023 18:53

Local test failed, seems the related to implemented changes one @JeneaVranceanu

@JeneaVranceanu
Copy link
Collaborator Author

@janndriessen @yaroslavyaroslav Ready for review. Tests pass.

janndriessen
janndriessen approved these changes Feb 4, 2023
View reviewed changes
Copy link
Collaborator

@janndriessen janndriessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it.

@yaroslavyaroslav yaroslavyaroslav merged commit e08de34 into web3swift-team:develop Feb 4, 2023
@JeneaVranceanu JeneaVranceanu deleted the feat/convert-bool-to-data branch February 5, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janndriessen janndriessen janndriessen approved these changes

@yaroslavyaroslav yaroslavyaroslav yaroslavyaroslav approved these changes

Assignees

@JeneaVranceanu JeneaVranceanu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JeneaVranceanu @janndriessen @yaroslavyaroslav