Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: web3 wallet example #764

Merged
merged 2 commits into from Feb 9, 2023
Merged

fix: web3 wallet example #764

merged 2 commits into from Feb 9, 2023

Conversation

JeneaVranceanu
Copy link
Collaborator

Summary of Changes

The example app didn't build and was basically broken.

  • removed CocoaPods from it. Used SPM instead;
  • updated to the latest APIs of web3swift;
  • set all keystore passwords to an empty string.

Test Data or Screenshots

By submitting this pull request, you are confirming the following:
  • I have reviewed the Contribution Guidelines.
  • I have performed a self-review of my own code.
  • I have updated my repository to match the develop branch.
  • I have included test data or screenshots that prove my fix is effective or that my feature works.
  • I have checked that all tests work and swiftlint is not throwing any errors/warnings.

@JeneaVranceanu JeneaVranceanu self-assigned this Feb 6, 2023
@JeneaVranceanu
Copy link
Collaborator Author

There's basically only one file to review: WalletViewController.swift.

@JeneaVranceanu JeneaVranceanu mentioned this pull request Feb 6, 2023
Closed
@yaroslavyaroslav yaroslavyaroslav mentioned this pull request Feb 9, 2023
Closed
janndriessen
janndriessen previously approved these changes Feb 9, 2023
View reviewed changes
@JeneaVranceanu JeneaVranceanu merged commit cdf789b into web3swift-team:develop Feb 9, 2023
@JeneaVranceanu JeneaVranceanu deleted the fix/web3-wallet-example branch February 9, 2023 22:51
cclauss pushed a commit to cclauss/web3swift that referenced this pull request Feb 10, 2023
@JeneaVranceanu @cclauss
parent 3081a92
ebc9f53 
parent 2c3a236
author Jenea Vranceanu <36865532+JeneaVranceanu@users.noreply.github.com> 1675983082 +0200
committer Christian Clauss <cclauss@me.com> 1676021928 +0100

parent 3081a92
parent 2c3a236
author Jenea Vranceanu <36865532+JeneaVranceanu@users.noreply.github.com> 1675983082 +0200
committer Christian Clauss <cclauss@me.com> 1676021923 +0100

parent 3081a92
parent 2c3a236
author Jenea Vranceanu <36865532+JeneaVranceanu@users.noreply.github.com> 1675983082 +0200
committer Christian Clauss <cclauss@me.com> 1676021917 +0100

Merge pull request web3swift-team#764 from JeneaVranceanu/fix/web3-wallet-example

fix: web3 wallet example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janndriessen janndriessen janndriessen approved these changes

@yaroslavyaroslav yaroslavyaroslav yaroslavyaroslav approved these changes

Assignees

@JeneaVranceanu JeneaVranceanu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JeneaVranceanu @janndriessen @yaroslavyaroslav