Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose Data Models For Public use #790

Merged
merged 24 commits into from Apr 2, 2023
Merged

Expose Data Models For Public use #790

merged 24 commits into from Apr 2, 2023

Conversation

pharms-eth
Copy link
Collaborator

Summary of Changes

Makes some properties and functions public

@JeneaVranceanu JeneaVranceanu requested review from janndriessen and yaroslavyaroslav and removed request for skywinder and BaldyAsh March 9, 2023 08:16
@JeneaVranceanu
Copy link
Collaborator

@pharms-eth Sorry for the long delay.
Could you please describe your intentions that led to these changes? Just curious. I do not see any particular issues with adding that to the release but wondering what were you trying to achieve.

@pharms-eth
Copy link
Collaborator Author

@pharms-eth Sorry for the long delay. Could you please describe your intentions that led to these changes? Just curious. I do not see any particular issues with adding that to the release but wondering what were you trying to achieve.

storing the values using my own algorithms

@JeneaVranceanu JeneaVranceanu mentioned this pull request Apr 2, 2023
Merged
@yaroslavyaroslav yaroslavyaroslav merged commit cdfb984 into web3swift-team:develop Apr 2, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaroslavyaroslav yaroslavyaroslav yaroslavyaroslav approved these changes

@JeneaVranceanu JeneaVranceanu JeneaVranceanu approved these changes

@janndriessen janndriessen Awaiting requested review from janndriessen

Assignees
No one assigned
Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pharms-eth @JeneaVranceanu @yaroslavyaroslav