Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ABI decoder - crashing during the attempt to use data slices #808

Merged
merged 17 commits into from Apr 2, 2023

Conversation

JeneaVranceanu
Copy link
Collaborator

@JeneaVranceanu JeneaVranceanu commented Mar 29, 2023

Summary of Changes

Fixing ABI decoding issues. This PR is a combination of #803 and #802.

Test Data or Screenshots

By submitting this pull request, you are confirming the following:
  • I have reviewed the Contribution Guidelines.
  • I have performed a self-review of my own code.
  • I have updated my repository to match the develop branch.
  • I have included test data or screenshots that prove my fix is effective or that my feature works.
  • I have checked that all tests work and swiftlint is not throwing any errors/warnings.

@JeneaVranceanu JeneaVranceanu added the bug Something isn't working label Mar 29, 2023
@JeneaVranceanu JeneaVranceanu self-assigned this Mar 29, 2023
@JeneaVranceanu JeneaVranceanu changed the title Fix/abi decoder fix: ABI decoder - crashing during the attempt to use data slices Mar 29, 2023
- ABIDecoding getting data slice in followTheData changed to using start data index
@JeneaVranceanu
Copy link
Collaborator Author

@6od9i @zhangliugang I've combined your branches in this PR. Will change a few things and pass it for review to @yaroslavyaroslav and @janndriessen
@yaroslavyaroslav @janndriessen Both of #803 and #802 were reviewed previously so this branch is created just because there are 2 tests that were duplicated in these PRs. But that was a requirement as it was proof that the fixes are correct.

@yaroslavyaroslav yaroslavyaroslav merged commit d5cf381 into develop Apr 2, 2023
2 checks passed
@yaroslavyaroslav yaroslavyaroslav deleted the fix/abi-decoder branch April 2, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants