Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add useOutsideAlerter hook and fix dropdown #959

Merged
merged 3 commits into from Dec 16, 2022

Conversation

dani69654
Copy link
Collaborator

closes #958

Alt Text

@changeset-bot
Copy link

changeset-bot bot commented Dec 16, 2022

🦋 Changeset detected

Latest commit: eb59387

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@web3uikit/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2022

size-limit report 📦

Path Size
packages/core/dist/index.js 331.45 KB (+0.06% 🔺)
packages/icons/dist/index.es.js 131.36 KB (0%)
packages/web3/dist/index.js 1.5 MB (0%)
packages/web3uikit/dist/index.js 1.94 MB (+0.01% 🔺)

Copy link
Contributor

@BillyG83 BillyG83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow @dani69654 this is a very handy hook, not sure about the prop rename. its not visible or invisibly, just open or close

@dani69654
Copy link
Collaborator Author

dani69654 commented Dec 16, 2022

wow @dani69654 this is a very handy hook, not sure about the prop rename. its not visible or invisibly, just open or close

Hey @BillyG83 , good point with the naming.
Let me think on how to better name these

@AbhinavMV AbhinavMV merged commit f092dc6 into master Dec 16, 2022
@AbhinavMV AbhinavMV deleted the feat/dropdown-close-on-click-outside branch December 16, 2022 14:24
@github-actions github-actions bot mentioned this pull request Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dropdown] close on outside click
3 participants