Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Icons]: optional responsiveness #974

Merged
merged 4 commits into from Dec 29, 2022
Merged

[Icons]: optional responsiveness #974

merged 4 commits into from Dec 29, 2022

Conversation

AbhinavMV
Copy link
Collaborator

@AbhinavMV AbhinavMV commented Dec 29, 2022


name: 'Pull request'
about: A new pull request

New Pull Request

Checklist

  • I am not disclosing a vulnerability.
  • My code is conform the code style
  • I have made corresponding changes to the documentation
  • I have updated Typescript definitions when needed

Issue Description

Related issue: #967

Solution Description

Instead of div it is easier to use flex:none

Default is false for isResponsive prop

@changeset-bot
Copy link

changeset-bot bot commented Dec 29, 2022

🦋 Changeset detected

Latest commit: f8851b0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@web3uikit/icons Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Dec 29, 2022

size-limit report 📦

Path Size
packages/core/dist/index.js 338.96 KB (+0.03% 🔺)
packages/icons/dist/index.es.js 131.47 KB (+0.09% 🔺)
packages/web3/dist/index.js 1.5 MB (+0.01% 🔺)
packages/web3uikit/dist/index.js 1.95 MB (+0.03% 🔺)

@BillyG83 BillyG83 merged commit 12e63f3 into master Dec 29, 2022
@BillyG83 BillyG83 deleted the feat/icon-responsive branch December 29, 2022 12:19
@github-actions github-actions bot mentioned this pull request Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants