Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty Intersection of Barcodes Errors Out Plots #459

Open
adit-anand opened this issue Aug 16, 2023 · 4 comments
Open

Empty Intersection of Barcodes Errors Out Plots #459

adit-anand opened this issue Aug 16, 2023 · 4 comments
Assignees
Labels
bug Something isn't working javascript
Projects

Comments

@adit-anand
Copy link
Collaborator

Error handling needs to be implemented for plot generation when the set of intersecting barcodes (from pie chart sector selection) is empty.
image

@adit-anand adit-anand added bug Something isn't working javascript labels Aug 16, 2023
@adit-anand adit-anand self-assigned this Aug 16, 2023
@adit-anand adit-anand added this to To do in webgen via automation Aug 16, 2023
@adit-anand
Copy link
Collaborator Author

Resolved with most recent updates to branch "adit"

@adit-anand
Copy link
Collaborator Author

@enemeth19 At the moment, an empty barcode intersection results in plots being generated for all patients (i.e., we visualize all the patients' data when the filters produce an empty list of barcodes).

What are your thoughts on displaying a pop-up message indicating the combination of filters produces no barcodes?

@enemeth19
Copy link
Collaborator

@enemeth19 At the moment, an empty barcode intersection results in plots being generated for all patients (i.e., we visualize all the patients' data when the filters produce an empty list of barcodes).

What are your thoughts on displaying a pop-up message indicating the combination of filters produces no barcodes?

That definitely sounds like a good idea.

However, if a user does not make any selections at all in the data filtering (ie, pie chart) section, then I think we should still display the data for all patients in the heatmap and violin plots. How does that sound to you @adit-anand ?

@adit-anand
Copy link
Collaborator Author

That works with me, thank you for the input Erika.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working javascript
Projects
webgen
  
To do
Development

No branches or pull requests

2 participants