Switch to com.webos.service.location #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Tofee WIP, but it should be close to working already. Just need to test GPS on PP(P). The conf file in /etc/location needs to be updated for PP(P) still. Probably https://github.com/webosose/com.webos.service.location/blob/master/files/etc/gpsConfig.conf#L2 Probably we need /dev/ttyUSB1 or /dev/ttyUSB2 there. |
|
@Tofee https://bpa.st/5NQA Does look pretty OK on PPP. Just need to see how we want to do this config file per machine. But that's minor. |
Tofee
reviewed
Dec 29, 2023
...ebos/nyx-modules/nyx-modules/0008-Add-LuneOS-modules-and-machine-specific-cmake-file-t.patch
Show resolved
Hide resolved
- Add LuneOS key - Fix LS2 permissions - Fix location of config files Signed-off-by: Herman van Hazendonk <github.com@herrie.org>
…s.service.location Since location-service is mostly broken, let's use the one from OSE that at least works somewhat. Signed-off-by: Herman van Hazendonk <github.com@herrie.org>
There was an inconsistent usage of tabs, leading to values not being aligned. Also Yes/TRUE and No/FALSE were mixed. Signed-off-by: Herman van Hazendonk <github.com@herrie.org>
Signed-off-by: Herman van Hazendonk <github.com@herrie.org>
Signed-off-by: Herman van Hazendonk <github.com@herrie.org>
Herrie82
force-pushed
the
herrie/location
branch
from
3b0a938
to
c119a0b
Compare
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since our location-service is pretty much dead with GeoClue not working and Mozilla not providing a key, let's switch to OSE's one instead.
Signed-off-by: Herman van Hazendonk github.com@herrie.org