Update LS2 calls and fix notifications #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the new API's instead of legacy ones. Signed-off-by: Herman van Hazendonk <github.com@herrie.org>
11 tasks
…ication After replacing luna-next with LSM, we need to use Toasts from com.webos.service.notification instead of org.webosports.notifications. This will show us notifications on incoming SMS again :) Signed-off-by: Herman van Hazendonk <github.com@herrie.org>
Herrie82
force-pushed
the
herrie/notification
branch
from
59469b3
to
336b37f
Compare
While fixing the syntax, forgot to update the permissions, so it still wasn't working on device. This fixes it and displays the notifications for incoming messages again. Signed-off-by: Herman van Hazendonk <github.com@herrie.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.