Skip to content
This repository has been archived by the owner on Oct 20, 2021. It is now read-only.

refactor(router): use reach router and remove prop-types warnings in site console #26

Merged
merged 2 commits into from
Sep 11, 2018

Conversation

Kimi-Gao
Copy link
Member

@Kimi-Gao Kimi-Gao commented Sep 10, 2018

  • Make sure that you propose PR to right branch: bugfix for master, feature for latest active branch feature-x.x.
  • Make sure that you follow earth-ui's code convention.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Main changes:

  • Use reach router.
  • Remove prop-types warnings and error in site console:
    image
  • Use code-split in docs, split the dependent js file.
  • Use react/react-dom/prop-types cdn.

Reference issue:
#4

@Kimi-Gao Kimi-Gao self-assigned this Sep 10, 2018
@Kimi-Gao Kimi-Gao added PR: refactor A code change that neither fixes a bug nor adds a feature PR: docs Documentation only changes labels Sep 10, 2018
Copy link
Collaborator

@weiyuxuan weiyuxuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Kimi-Gao Kimi-Gao merged commit e2902a2 into feature-0.2 Sep 11, 2018
@Kimi-Gao Kimi-Gao deleted the upgrade-react-router branch September 11, 2018 05:25
@Kimi-Gao Kimi-Gao changed the title Use reach router and remove prop-types warnings in site console refactor(router): use reach router and remove prop-types warnings in site console Sep 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR: docs Documentation only changes PR: refactor A code change that neither fixes a bug nor adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants