Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release 0.6.0: router.currentRouteName is null #266

Closed
elgordino opened this issue Jan 30, 2018 · 1 comment · Fixed by #269
Closed

release 0.6.0: router.currentRouteName is null #266

elgordino opened this issue Jan 30, 2018 · 1 comment · Fixed by #269

Comments

@elgordino
Copy link

elgordino commented Jan 30, 2018 •
edited
Loading

I upgraded to ember-component-css 0.6.0 and found that currentRouteName and currentURL on the router service are both null. I use a pods project layout and route styles

This appears to be caused by this removal of a call to super: 6ff9a44#diff-a34e9abb0ed27cb3f049651554b3e977L7

Restoring that call to super restores currentRouteName on the router service.

I'm not sure on the intent on removing the call, I can submit a PR to restore it if it would be useful?
@webark
Copy link
Owner

webark commented Jan 30, 2018

That was a mistake. I’ll get that updated and a new version released when i get to a computer.

@webark webark mentioned this issue Jan 30, 2018
Merged
webark added a commit that referenced this issue Jan 30, 2018
@webark
fix(router): accidentally removed a import super call in the routers …
446a368 
…didTransition. fixes #266
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(router): accidentally removed a import super call
2 participants
@webark @elgordino