Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warnings with Ember 3.27 #365

Open
boris-petrov opened this issue May 17, 2021 · 5 comments
Open

Deprecation warnings with Ember 3.27 #365

boris-petrov opened this issue May 17, 2021 · 5 comments

Comments

@boris-petrov
Copy link

boris-petrov commented May 17, 2021

Importing global Ember is deprecated in Ember 3.27 and will be removed from Ember 4.

P.S. Reopening Ember.Component also.

@SergeAstapov
Copy link
Contributor

This can be fixed in a way similar to salsify/ember-css-modules#251 or mainmatter/ember-test-selectors#721

@webark
Copy link
Owner

webark commented Feb 4, 2022

@SergeAstapov I'm no longer maintaining this project, and any effort I do spend is being transitioned into its replacement https://github.com/webark/ember-cli-styles

There are a number of issues with how this addon accomplishes its features that are not compatible with Ember 4, so a rewrite was nessicary. It also means there are some features (like the automatic namespacing of components) that are no longer feasible.

Documentation of https://github.com/webark/ember-cli-styles is coming as well as a transition plan for those interested in making the switch.

@SergeAstapov
Copy link
Contributor

@webark totally understand that and really appreciate all the effort you put into https://github.com/webark/ember-cli-styles!

At this point I'm not sure how feasible the switch is and how close ember-cli-styles to release.
My thought process was that we may be able easily make this addon not break with Ember v4 because of Ember.Component.reopen and keep using it until ember-cli-styles is ready.

I'm happy to explore and PR an option I mentioned in the above PR meanwhile. Hope this makes sense

@webark
Copy link
Owner

webark commented Feb 4, 2022

ember-cli-styles is pretty close.. if you want to try to get a PR together for this, I'll be happy to review, give feedback, and merge. Without Ember.Component.reopen, this project can't function.

@boris-petrov
Copy link
Author

boris-petrov commented Feb 5, 2022

@SergeAstapov - ember-cli-styles is pretty fine. There's a few issues that remain for it to be fully production-ready (I've opened an issue for all of them I believe) but otherwise you can try it out now on your Ember 4 apps and tell us of any problems! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants