Add Embroider to CI tests #356
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds test scenarios for the new [Embroider](https://github.com/embroider-build/embroider) build system to ember-try and to the Travis config. These test currently fail since the generated `pod-styles` manifest can't be found. I've marked the failures as allowed in Travis.
|
@reidab Thanks. I haven't been doing ember (or general front end for that matter) development for a bit, so sorry that I have left this project in somewhat limbo. I'd like to explore getting this version of ECC running on embroider (have you tried the beta release?) so I'd prefer to merge it onto a new "embroider" branch where we can work towards getting that working. Does that seem fair? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds test scenarios for the new Embroider build system to ember-try and to the Travis config.
These test currently fail since the generated
pod-stylesmanifest can't be found. I've marked the failures as allowed in Travis.