Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash-pin workflow GitHub Actions #2290

Closed
pnacht opened this issue Sep 6, 2023 · 1 comment
Closed

Hash-pin workflow GitHub Actions #2290

pnacht opened this issue Sep 6, 2023 · 1 comment

Comments

@pnacht
Copy link
Contributor

pnacht commented Sep 6, 2023

Hey, it's Pedro (see #2245) and I'm back with a new security suggestion!

When developing with CI workflows, it's common to version-pin dependencies (i.e. actions/checkout@v3). However, version tags are mutable, so a malicious attacker could overwrite a version tag to point to a malicious or vulnerable commit instead.

Pinning workflow dependencies by hash ensures the dependency is immutable and its behavior is guaranteed.

These hashes can be automatically updated by dependabot. Whenever new versions Actions are released, you'll receive a single PR updating all of their hashes and version comments at once (see this example).

I'll send a PR pinning the Actions along with this issue.

@keithw
Copy link
Member

keithw commented Sep 15, 2023

Closing for now per discussion on #2291

@keithw keithw closed this as completed Sep 15, 2023
@keithw keithw closed this as not planned Won't fix, can't repro, duplicate, stale Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants