Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WASM2C - What happened to wasm_rt_allocate_memory #2391

Closed
woodsmc opened this issue Feb 12, 2024 · 3 comments
Closed

WASM2C - What happened to wasm_rt_allocate_memory #2391

woodsmc opened this issue Feb 12, 2024 · 3 comments

Comments

@woodsmc
Copy link

woodsmc commented Feb 12, 2024

The function prototype is available in the header file: wasm-rt.h line : 512

But is missing from the implementation file : wasm-rt-impl.c, it appears to have been removed here - 80b4f08

Has it be deprecated? or has the function implementation been moved to another .c file?

@keithw
Copy link
Member

keithw commented Feb 12, 2024

Hello Chris -- see https://github.com/WebAssembly/wabt/blob/main/wasm2c/wasm-rt-mem-impl-helper.inc#L66-L94 , included at https://github.com/WebAssembly/wabt/blob/main/wasm2c/wasm-rt-mem-impl.c#L161 .

The wasm2c README has just been updated (thanks to you) to include the additional source file: https://github.com/WebAssembly/wabt/blob/main/wasm2c/README.md?plain=1#L116

(BTW I replied to your email on this earlier today -- did it not arrive?)

@shravanrn
Copy link
Collaborator

Documented in PRs #2390 #2392

@woodsmc
Copy link
Author

woodsmc commented Feb 15, 2024

Thanks folks. I missed the email, but really appreciate the support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants