Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EdDSA support #662

Merged
merged 3 commits into from
May 29, 2022
Merged

Add EdDSA support #662

merged 3 commits into from
May 29, 2022

Conversation

ynojima
Copy link
Member

@ynojima ynojima commented May 25, 2022

Breaking changes:

  • SignatureAlgorithm 's String constants are removed.
  • ECUtil.convertToFixedByteArray is moved to ArrayUtil.convertToFixedByteArray
  • Curve#getECParameterSpec is renamed to Curve#getParameterSpec, and now returns AlgorithmParameterSpec instead of ECParameterSpec

Note:
EdDSA is only supported on JDK15+. If you try to use EdDSA on JDK14 or below an exception will be thrown.

@ynojima ynojima force-pushed the add-eddsa-support branch 2 times, most recently from d5d3122 to 994647f Compare May 25, 2022 15:09
@ynojima ynojima added the breaking change Breaks existing interface label May 25, 2022
@ynojima ynojima force-pushed the add-eddsa-support branch 6 times, most recently from 78c6cc1 to 01d2cfb Compare May 28, 2022 13:25
@sonarcloud
Copy link

sonarcloud bot commented May 28, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

66.0% 66.0% Coverage
0.0% 0.0% Duplication

@ynojima ynojima force-pushed the add-eddsa-support branch 10 times, most recently from e011214 to 7e9ad84 Compare May 29, 2022 05:50
@ynojima ynojima marked this pull request as ready for review May 29, 2022 06:10
@ynojima ynojima changed the title Add eddsa support Add EdDSA support May 29, 2022
@ynojima ynojima force-pushed the add-eddsa-support branch 2 times, most recently from 6190029 to ea1d5c8 Compare May 29, 2022 11:09
@sonarcloud
Copy link

sonarcloud bot commented May 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

89.2% 89.2% Coverage
0.0% 0.0% Duplication

@ynojima ynojima merged commit 17d46df into master May 29, 2022
@ynojima ynojima deleted the add-eddsa-support branch May 29, 2022 11:23
@ynojima ynojima added this to the 0.20.0.RELEASE milestone Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Breaks existing interface
Development

Successfully merging this pull request may close these issues.

None yet

1 participant