Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo sword sounds + grunts #3659

Open
avaer opened this issue Aug 21, 2022 · 2 comments
Open

Redo sword sounds + grunts #3659

avaer opened this issue Aug 21, 2022 · 2 comments
Assignees

Comments

@avaer
Copy link
Contributor

avaer commented Aug 21, 2022

The sword sounds and grunts were implemented in the silsword app, which is the wrong place: https://github.com/webaverse/silsword/blob/df1cbb2cfb9a8f7eb9967d9159003d6c4e73a84e/index.js#L698

The character shape will change, which it did upstream, and now the silsword crashes, so I removed the grunt.

The grunt should occur, like the footsteps and jump, in response to actions on the avatar, implemented in the character controller system. And the avatar controller should emit a sound point event, so that the sword can play its whoosh sound too (silsword should listen for the event).

@tcm390 https://github.com/webaverse/silsword/blame/df1cbb2cfb9a8f7eb9967d9159003d6c4e73a84e/index.js#L698

@avaer
Copy link
Contributor Author

avaer commented Aug 21, 2022

@avaer avaer changed the title Redo sword grunts Redo sword sounds + grunts Aug 21, 2022
@tcm390 tcm390 self-assigned this Aug 21, 2022
@patriboz
Copy link
Contributor

patriboz commented Sep 8, 2022

Fix: #3694

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants