Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPEC] DKG Gadgets Refactoring #70

Closed
6 tasks
shekohex opened this issue Jan 12, 2022 · 0 comments · Fixed by #82
Closed
6 tasks

[SPEC] DKG Gadgets Refactoring #70

shekohex opened this issue Jan 12, 2022 · 0 comments · Fixed by #82
Assignees
@shekohex @temld4

Comments

@shekohex
Copy link
Contributor

shekohex commented Jan 12, 2022 •
edited
Loading

Rounds (dkg-primitives/src/rounds.rs)

  • Split into smaller modules
    • Traits for Keygen and Sign
    • Move Keygen and Sign impl into separate file
  • Improve the code readability and add comments when possible.
    • User Builder Patteren for the MultiPartyECDSARounds, see the typed_builder crate.
  • Refactor and run Clippy over the code.
@drewstone drewstone linked a pull request Jan 19, 2022 that will close this issue
Refactor DKG rounds #82
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shekohex shekohex

@temld4 temld4

Labels
None yet
Projects
No open projects
DKG
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor DKG rounds webb-tools/dkg-substrate
2 participants
@shekohex @temld4